Efficy Overflow Q&A - Recent questions in Major bug fixes

10.2.8930: Bug in globals OpenEdit and ParseDuration due to windowManager introduction

Fri, 27 Jan 2017 11:47:26 +0000

Efficy 10.2 re-introduces the window manager to store and restore the size of opened windows. Related to these changes, two issues have been identified.

The patch code below can be applied to your 10.2 release to fix them:

One: Opening a second edit window for the same entity (e.g. appointment) is not possible. The focus is forwarded to the first opened window of the same entity. Below the fixed standard function.

function OpenEdit(Page, Entity, Key, Action, ExtraParam) {
    var URL = "edit?page=" + Page + "&entity=" + Entity + "&key=" + Key + "&action=" + EscapeName(Action)
    if (ExtraParam) URL += "&" + ExtraParam;
    if (Key === 0)
           Key = '0' + GetRandom();
    var wnd = OpenNewWindow('Edit' + Entity + Key, URL, 1014, 0, '', true);
    return wnd
}

Two: In some situations, the task duration was not correctly translated to a number.

Replace this code snippet in standard

function ParseDuration(val) {
                if (val == "") return 0

with

function ParseDuration(val) {
    // Only parse duration text, not number
    if (!isNaN(val)) return +val;
    if (val.trim() === '') return 0;

We will continue to use this category for future known issues

R6640 - Actions not displayed in the Agenda

Thu, 22 Oct 2015 09:57:09 +0000

Dear All,

After an upgrade from R6100 to R6640, the actions are not displayed in the agenda.

This is due to the fact that some data that were previously in the table ACTIONS need to be on the table ACTI_USER.

To move this data from the table ACTIONS to ACTI_USER, you need to execute a query :

For SQL SERVER (to execute in SQL Server Management Studio) :

UPDATE au
SET 
    P_D_BEGIN = cast(a.D_BEGIN as int) + 1, 
    P_D_END =  cast(a.D_END as int) + 1, 
    ISAGENDA = (SELECT
    CASE 
        WHEN a.PLANNED = '1' AND au.ISACTIVE = '1' AND (au.STATUS IS NULL OR au.STATUS IN ('', '0', '2', '3', '5', '6')) 
        THEN '1' 
        ELSE '0' 
    END)
FROM
 [Admin].ACTI_USER au
LEFT JOIN 
 [Admin].ACTIONS a ON a.K_action = au.k_action;

For Oracle (to execute in SQL Developer):

DECLARE 

TYPE T_ROWID_ARRAY IS TABLE OF ROWID; 

CURSOR C_ACTI_USER IS 

SELECT ROWID 

FROM ACTI_USER 

WHERE P_D_BEGIN IS NULL; 

V_ROWID_ARRAY T_ROWID_ARRAY; 

V_LIMIT NUMBER := 1000; 

BEGIN 

OPEN C_ACTI_USER; 

LOOP 

FETCH C_ACTI_USER BULK COLLECT 

INTO V_ROWID_ARRAY 

LIMIT V_LIMIT; 

FORALL I IN 1 .. V_ROWID_ARRAY.COUNT 

UPDATE ACTI_USER 

SET 

P_D_BEGIN = (SELECT to_number(to_char(D_BEGIN, 'j')) - 2415019 FROM ACTIONS WHERE K_ACTION=ACTI_USER.K_ACTION), 

P_D_END = (SELECT to_number(to_char(D_end, 'j')) - 2415019 FROM ACTIONS WHERE K_ACTION=ACTI_USER.K_ACTION), 

ISAGENDA = 

(SELECT 

CASE 

WHEN ACTIONS.PLANNED = '1' AND ACTI_USER.ISACTIVE = '1'  AND (ACTI_USER.STATUS IS NULL OR ACTI_USER.STATUS IN ('', '0', '2', '3', '5', '6')) 

THEN '1' 

ELSE '0' 

END CASE 

FROM ACTIONS 

JOIN ACTI_USER ON ACTIONS.K_ACTION = ACTI_USER.K_ACTION 

and acti_user.rowid = V_ROWID_ARRAY(I)) 

WHERE 

ROWID = V_ROWID_ARRAY(I); 

COMMIT; 

EXIT WHEN C_ACTI_USER%NOTFOUND; 

END LOOP; 

CLOSE C_ACTI_USER; 


END; 

/

Geoffrey

R6640 : Is there a way to import 5min meeting in the timesheet

Thu, 15 Oct 2015 14:00:22 +0000

Dear all,

We have a client in 2012 summer with a custom allowing him to import 5 minutes meeting in his timesheet. This client want a migration to the 2014. Is it possible to do the same custom in 2014 build 6640? I tried this morning and wasnt successful, we can import 10 minutes meeting but the duration is rounded to 15. I of course tried with 5 minutes meeting but it doesn't import at all.

Thanks in advance,

Stéphane Xerri

Conficy : Add Language and Add External Key (all 2014 versions <= R6100)

Fri, 17 Jul 2015 13:35:51 +0000

Dear Efficy Developers,

In every Efficy versions <=R6100, the option "Add External Key Fields" and "Add Language Field" in Conficy are bugged.

This is a major issue as the process is not ending correctly and sometimes create duplicates objects in the database (so you wouldn't be able do do a Database Upgrade if this happend).

Here is the fix :

in conficy/pages/LookupEdit.htm, replace the functions AddLanguageField() and AddExternalKeyField by :

function AddLanguageField() {
   var LangSel = document.getElementById("LangFields")
   if (LangSel.style.display == "none") {
                   LangSel.style.display = "inline"
                   return
   }
   var NewLanguageField = LangSel.options[LangSel.selectedIndex].value
   if (confirm(msgAddLanguageField + "\n" + NewLanguageField)) {
                   var URL = "commitlookup?table=<%GetArgument('Table')%>&page=pages/DatabaseProgress.htm" +
                          "&finishbookmark=<%GetBookmark(ftext='')%>&action=addlanguagefield&field=" + NewLanguageField;
                   location.href = URL;
   }
}
function AddExternalKeyField() {
   if (confirm(msgAddExternalKeyField)) {
                   var URL = "commitlookup?table=<%GetArgument('Table')%>&page=pages/DatabaseProgress.htm" +
                            "&finishbookmark=<%GetBookmark(ftext='')%>&action=addexternalkeyfield";
                   location.href = URL;
   }
}

Geoffrey

R6100 - Import from Timesheet not working

Fri, 17 Jul 2015 13:05:43 +0000

Dear fellow Efficy Developers,

The request Agenda: Self has been optimized in order to lower the response time when displaying the Agenda, but causes troubles when importing actions from the agenda (so not for tasks) in the Timesheet (it just doesn’t work anymore because one value is not gathered).

So we need to modify in the table SYSQUERIES the SQLTEXT value for the record KMASTER=35 and K_DETAIL=1, and put the following value :

[Select]
ACTIONS.K_ACTION
ACTIONS.DONE
ACTIONS.D_BEGIN
ACTIONS.D_END
ACTIONS.PLANNED hidden
ACTIONS.SUBJECT
ACTIONS.D_CHANGE
ACTIONS.MODE
ACTIONS.NATURE
ACTIONS.TRAVELBEFORE
ACTIONS.TRAVELAFTER
ACTIONS.TIMEZONE
ACTIONS.TIMEZONE [TZMODIFIED]
ACTIONS.LOCATION
ACTIONS.USERS
ACTIONS.ALLDAYEVENT
ACTIONS.P_D_BEGIN hidden
ACTIONS.P_D_END hidden
ACTI_PROJ.K_PROJECT
ACTI_PROJ.MAIN hidden

[From]
ACTIONS
ACTIONS ACTI_PROJ complete

[Where]
ACTIONS.P_D_END >= "1/1/2000"
ACTIONS.P_D_BEGIN < "2/1/2000"
<#USERLINK table="ACTIONS" usertable="ACTI_USER" key="K_ACTION" isactiveparam="true" actionstatus="true">
ACTIONS.PLANNED = 1 [fixed]
ACTI_PROJ.MAIN = 1 [fixed]

[Orderby]

[Columns]

Be aware that in the next release there will be changes in the import from the Timesheet, so the field ISCUSTOM=1 should be changed to ISCUSTOM=0 just before the next Database Upgrade.

Geoffrey

Bug on Relation Edit with IE 11 on R6099 and R6100

Tue, 07 Jul 2015 09:46:56 +0000

Dear Efficy Developers/Partners,

I post this on the Overflow to inform the Efficy Developers that on the build R6099 and R6100 there is a bug on IE that make impossible to edit a relation.

Here is the fix :

Add in custom.js :

/* FIX - TO BE DELETED ON A BUILD > R6100 */ 
function EditRelation(Page, Entity, Key, Detail, DetailKey) {
                var URL = "edit?page=" + Page + "&action=RefreshOpener()&entity=" + Entity + "&key=" + Key + "&detail=" + Detail + "&detailkey=" + DetailKey
                var Test = IsSearchWindow || Relocating;
                var Opener = (Test && OpenerExists()) ? top.opener : window;
                var wnd = Opener.OpenNewWindow(Entity + Detail + "Edit", URL, 600, 400, "Edit" + Entity + Key + Detail + DetailKey, true)
                if (Test)
                               CloseTopWindow()
}

/* END FIX*/

NB : this does NOT applies to ASP customers as this fix has been modified directly in the standard file (Efficy.js) on ASP.

Geoffrey