Efficy Overflow Q&A - Recent questions tagged dataset

Is it better to "openEditContextRelation" or "TDataSet.edit() / TDataSet.post()" ?

Sat, 25 May 2019 19:36:06 +0000

Hello,

Let's imagine I need to mass update the quantity of the products linked to a document.

Would it be better to do :
The "openEditContextRelation" method

var dsProducts = Efficy.getDetailDataSet(docuCtx, ntProd);
            if(dsProducts.isEmpty()) return;

            dsProducts.first();

while (!dsProducts.eof()) {

                var docuProdCtx = Efficy.openEditContextRelation(ntDocu, ntProd, this.k_document, dsProducts.fieldByName('K_PRODUCT').asFloat, dsProducts.fieldByName('K_RELATION').asFloat)
                try {

                    var dsDocuProd = Efficy.getMasterDataSet(docuProdCtx, 0);
                    dsDocuProd.edit();

                    dsDocuProd.fieldByName('QUANTITY').asInteger = -1;
                    dsDocuProd.fieldByName('TOTAL').asFloat = - dsProducts.fieldByName('TOTAL').asFloat;
                    dsDocuProd.fieldByName('F_TOTAL_TVAC').asFloat = - dsProducts.fieldByName('F_TOTAL_TVAC').asFloat;

                    if(dsProducts.fieldByName('F_ISTIMESHEET').asInteger) {
                        this.Time.lockManagement(dsProducts.fieldByName('F_EXT_KEY').asFloat, 1, 0);
                    }

                    Efficy.commitChanges(docuProdCtx, false);

                } finally {
                   Efficy.closeContext(docuProdCtx)
                }

            }

or the TDataSet.edit() / TDataSet.post() ( My personal choice )

var dsProducts = Efficy.getDetailDataSet(docuCtx, ntProd);
            if(dsProducts.isEmpty()) return;

            dsProducts.first();

            while (!dsProducts.eof()) {

                dsProducts.edit();

                dsProducts.fieldByName('QUANTITY').asInteger = -1;
                dsProducts.fieldByName('TOTAL').asFloat = - dsProducts.fieldByName('TOTAL').asFloat;
                dsProducts.fieldByName('F_TOTAL_TVAC').asFloat = - dsProducts.fieldByName('F_TOTAL_TVAC').asFloat;

                if(dsProducts.fieldByName('F_ISTIMESHEET').asInteger) {
                    this.Time.lockManagement(dsProducts.fieldByName('F_EXT_KEY').asFloat, 1, 0);
                }

                dsProducts.post();
                dsProducts.next();

            }
// this operation end with a commit on docuCtx and a closeContext

I never saw the second choice anywhere, in the old project I manage. Is it really a good idea ? I found more convinient to use the TDataSet.edit() / TDataSet.post() method, because you don't need to commit at each iteration;

Thanks in advance,

Loïc

Get only what's change during the edit context

Tue, 12 Mar 2019 07:49:17 +0000

Hello Efficy Team,

I got a complex process where I need to do something with the "new element" of a detailDataSet, or the deleted elements of the detailDataSet during the edit context.

What is the best way retrieve only those element ?

Here is what I did :

    var k_project = Efficy.getEditKey(editHandle);
var relationTable = Efficy.entityCatalog.getRelationEntityTableName(ntProj, TEntityHandle);
var kElement = Efficy.entityCatalog.keyFieldName(TEntityHandle);

var dsDetails = Efficy.sqlQueryDataSet('select * from ' + relationTable + ' where k_project = :param1', k_project, 45);
var newDetails = Efficy.getDetailDataSet(editHandle, TEntityHandle);

var changesInTheEditContext = [];

if(dsDetails || !dsDetails.isEmpty()) {

    // the project is already committed. We need to get only the "new" one
    // for that, we filter the "new one" based on the "old one"

    var existing = [];
    dsDetails.first();
    while (!dsDetails.eof()) {
        existing.push(dsDetails.fieldByName(kElement).asFloat);
        dsDetails.next();
    }

    // ho yeah it is ugly. But seems that "not in ()" does not work
    newDetails.filter = kElement +' <> ' + existing.join(' AND ' +  kElement +  ' <> ');
    newDetails.FilterOptions = existing.length;
    newDetails.Filtered = true;

}

// then we get, for each "new one", useful information's : entity, key, name

if(newDetails.isEmpty() || !newDetails) return false;
newDetails.first();

while(!newDetails.eof()) {

    changesInTheEditContext.push({
        entity : Efficy.entityCatalog.getEntityName(TEntityHandle),
        key : newDetails.fieldByName(kElement).asFloat,
        name : getName(newDetails.fieldByName(kElement).asFloat, TEntityHandle),
        operation : 'add'
    })

    newDetails.next();
}

newDetails.Filtered = false;

// we also need to detect the opposite : a contact deleted during the edit context
// we use the same ticks, but in the opposite (current detailDataSet filter the SQL)

if(dsDetails || !dsDetails.isEmpty()) {

    var fromRelationTable = [];

    newDetails.first();
    while (!newDetails.eof()) {

        fromRelationTable.push(newDetails.fieldByName(kElement).asFloat);
        newDetails.next();

    }

    // ho yeah it is ugly. But seems that "not in ()" does not work
    dsDetails.filter = kElement +' <> ' + fromRelationTable.join(' AND ' +  kElement +  ' <> ');
    dsDetails.FilterOptions = fromRelationTable.length;
    dsDetails.Filtered = true;

    if(dsDetails.isEmpty() || !dsDetails) return false;
    dsDetails.first();

    while(!dsDetails.eof()) {

        changesInTheEditContext.push({
            entity : Efficy.entityCatalog.getEntityName(TEntityHandle),
            key : dsDetails.fieldByName(kElement).asFloat,
            // name : getName(newDetails.fieldByName(kElement).asFloat, TEntityHandle), -- we don't need the name, he's already displayed
            operation : 'delete'
        })

        dsDetails.next();
    }

    dsDetails.Filtered = true;

}

return changesInTheEditContext;

Is there, by any chance, a way to get those change in a more "Efficy way" than comparing two dataSet ?

Regards,

Loïc

get the result of a select statement to an array of object

Fri, 09 Feb 2018 14:36:11 +0000

Dear developper community

Just before Kristof tells me why it's not good^^ let s take a minute to celebrate my new Achievement : I finally found a way to convert Dataset to Array of Objects in javascript. please note that this is the result of delphi Recordset objects researches on the web plus lot of tests.

I give you the result of my code as a tribute for the great Efficy developpers community^^.

this is how it works : in my example I try to get all the STATUS_FR and K_OPPO_STATUS from the LK_OPPO_STATUS table ENALBED and with K_OPPO_STATUS lesser than 5
do you remember doing something like this :

var
    result = new Array(),
    qh = 0,
    context = Database.OpenTemporaryContext(),
    sql = "select * from <#TABLE NAME=LK_OPPO_STATUS> where DISABLED = :param1 and K_OPPO_STATUS < :param2",
    params = [0, 5].join("\n"),
    ds = Database.ExecuteSystemSQLQuery(qh, context, sql, params, true, true, 1);

while (!ds.EoF){

    result.push({
        status: ds.FieldByName("STATUS").AsString,
        k_oppo_status: ds.FieldByName("K_OPPO_STATUS").AsFloat      
    });

    ds.Next();
}

return result;

that gave you :

[  
   {  
      "status_fr":"01. Prise de contact",
      "k_oppo_status":1
   },
   {  
      "status_fr":"02. Qualification",
      "k_oppo_status":2
   },
   {  
      "status_fr":"03. Démonstration",
      "k_oppo_status":3
   },
   {  
      "status_fr":"04. Offre",
      "k_oppo_status":4
   }
]

this time my friends is over! now you can do :

return jsonSelectSQL("select * from <#TABLE NAME=LK_OPPO_STATUS> where DISABLED = :param1 and K_OPPO_STATUS < :param2", 0, 5);

Note that at this point YOU don't need to specify anything about the fields names or number of fields.

which will give you something like

[  
   {  
      "k_oppo_status":1,
      "k_sort":1,
      "k_label":0,
      "status":"01. Initial Contact",
      "disabled":"0",
      "status_fr":"01. Prise de contact",
      "status_nl":"01. Prise de contact",
      "status_es":"01. Prise de contact",
      "status_de":"01. Prise de contact",
      "status_ja":"",
      "status_pl":"",
      "status_tr":"",
      "status_ar":"",
      "f_pending":1
   },
   {  
      "k_oppo_status":2,
      "k_sort":2,
      "k_label":0,
      "status":"02. Qualification",
      "disabled":"0",
      "status_fr":"02. Qualification",
      "status_nl":"02. Accroche",
      "status_es":"02. Accroche",
      "status_de":"02. Accroche",
      "status_ja":"",
      "status_pl":"",
      "status_tr":"",
      "status_ar":"",
      "f_pending":1
   },
   {  
      "k_oppo_status":3,
      "k_sort":3,
      "k_label":0,
      "status":"03. Démonstration",
      "disabled":"0",
      "status_fr":"03. Démonstration",
      "status_nl":"03. Démonstration",
      "status_es":"03. Démonstration",
      "status_de":"03. Démonstration",
      "status_ja":"",
      "status_pl":"",
      "status_tr":"",
      "status_ar":"",
      "f_pending":1
   },
   {  
      "k_oppo_status":4,
      "k_sort":4,
      "k_label":0,
      "status":"04. Offre",
      "disabled":"0",
      "status_fr":"04. Offre",
      "status_nl":"04. Offre",
      "status_es":"04. Offre",
      "status_de":"04. Offre",
      "status_ja":"",
      "status_pl":"",
      "status_tr":"",
      "status_ar":"",
      "f_pending":1
   }
]

note that if you strictly want the same result as before you can do :

return jsonSelectSQL("select STATUS_FR, K_OPPO_STATUS from <#TABLE NAME=LK_OPPO_STATUS> where DISABLED = :param1 and K_OPPO_STATUS < :param2", 0, 5);

this is the code of jsonSelectSQL :

function jsonSelectSQL(){

    var 
        ds = selectSQL.apply(null, arguments),
        result = new Array(),
        fields = new Array();

    ds.First();
    if (!ds.EoF) {
        for (var i=0; i<ds.Fields.count; i++){
            fields.push(ds.Fields(i).FieldName);
        }
    }
    while (!ds.EoF){
        var obj = {};

        for (var i=0; i<fields.length; i++) {
            var temp = ds.FieldByName(fields[i]).Value;
            switch(typeof(temp)){
                case "string":
                    obj[fields[i].toLowerCase()] = temp;
                    break;
                case "number": 
                    obj[fields[i].toLowerCase()] = Number(temp);
                    break;
                default: 
                    obj[fields[i].toLowerCase()] = temp;
                    break;
            }
        }
        result.push(obj);

        ds.Next();
    }
    return result;
}

please note that you will need this code as well :

//------(simple closure to don't have to remember which StoreId to use)
var nextStoreId = (function(){
    var storeId = 0;
    return function(){return storeId += 1;};
})();

//------(call this with sql string and parameters and you will get the standard dataset)
function selectSQL(){
    var 
        args = arrayFrom(arguments),
        qh = 0, 
        context = Database.OpenTemporaryContext(),
        sql = args[0],
        params = args.splice(0,1),
        ds = Database.ExecuteSystemSQLQuery(qh, context, sql, params.join("\n"), true, true, nextStoreId());

    return ds;
}

//-----(convert the classic arguments arraylike object as a regular javascript array)
function arrayFrom(_arg){

    var result = new Array();

    for (var i=0; i<_arg.length; i++){
        result.push(_arg[i]);
    }

    return result;
}   

//-----(home made splice prototype polyfill, feel free to use yours)
Array.prototype.splice = function(){
    var args = arguments;

    var result = new Array();
    var i = 0;

    if (args[0] + args[1] > this.length) throw new Error("custom Splice error, invalid parameters for this array");
    while (i < args[0]){
        result.push(this[i]);
        i++;
    }

    if (args[2])    for (var j=0; j<args[2].length; j++) result.push(args[2][j]);

    i = args[0] + args[1];

    while (i<this.length){
        result.push(this[i]);
        i++;
    }

    for (i=0; i<this.length; i++) this[i] = undefined;
    this.length = 0;
    for (i=0; i<result.length; i++) this.push(result[i]);

    return this;
}

since a lot of code can be necessary I invite to use my previous achievement : be able to make some include files in serverscripts files : I have it updated so this in the header of your serverscript file will make the trick :

eval(function (_files){
    var root = "C:/inetpub/wwwroot/efficy/" + ((typeof(Request) !== "undefined")? Request.CustomBaseURL: "../customs/Test/");
    var result = "";
    for (var i=0; i<_files.length; i++) result += (StrLoadBinaryFile(root + _files[i])) + "\r\n";
    return result;
}([
    "serverscripts/NL_server_tools.js"
    ,"serverscripts/NL_server.js"
    ,"serverscripts/json2.js"
]));

in this example I chose to regroup all Efficy specific functions in NLserver.js
and all the pure javascripts tools as the splice polyfill in NLserver_tools.js
libjson is the copy of the standard libjson library used sometimes in some scripts. (JSON.parse and stringify)

Cheers. feel free to improve this code or ask for all the librairies if you need it
please share your code afterward.

How to found the list of columns of a DataSet ?

Fri, 21 Oct 2016 08:28:35 +0000

Hi to all,

I want to write a "generic" function to read data via a SQL request...
The problem is that I don't know the list of columns inside the Dataset result, while the query is build +/- dynamically...

 var mysql = "select * from COMPANIES"   // <- query unknow 
 var myDataSet = Database.ExecuteSystemSQLQuery(0, Database.OpenTemporaryContext, mysql, null, true, true, 36); //

Is a way to obtain something like :

var columns = myDataSet.Columns(); //   [ 'K_COMPANY', 'NAME',... ]

Regards
Didier