Is it better to "openEditContextRelation" or "TDataSet.edit() / TDataSet.post()" ?

Sat, 25 May 2019 19:36:06 +0000

Hello,

Let's imagine I need to mass update the quantity of the products linked to a document.

Would it be better to do :
The "openEditContextRelation" method

var dsProducts = Efficy.getDetailDataSet(docuCtx, ntProd);
            if(dsProducts.isEmpty()) return;

            dsProducts.first();

while (!dsProducts.eof()) {

                var docuProdCtx = Efficy.openEditContextRelation(ntDocu, ntProd, this.k_document, dsProducts.fieldByName('K_PRODUCT').asFloat, dsProducts.fieldByName('K_RELATION').asFloat)
                try {

                    var dsDocuProd = Efficy.getMasterDataSet(docuProdCtx, 0);
                    dsDocuProd.edit();

                    dsDocuProd.fieldByName('QUANTITY').asInteger = -1;
                    dsDocuProd.fieldByName('TOTAL').asFloat = - dsProducts.fieldByName('TOTAL').asFloat;
                    dsDocuProd.fieldByName('F_TOTAL_TVAC').asFloat = - dsProducts.fieldByName('F_TOTAL_TVAC').asFloat;

                    if(dsProducts.fieldByName('F_ISTIMESHEET').asInteger) {
                        this.Time.lockManagement(dsProducts.fieldByName('F_EXT_KEY').asFloat, 1, 0);
                    }

                    Efficy.commitChanges(docuProdCtx, false);

                } finally {
                   Efficy.closeContext(docuProdCtx)
                }

            }

or the TDataSet.edit() / TDataSet.post() ( My personal choice )

var dsProducts = Efficy.getDetailDataSet(docuCtx, ntProd);
            if(dsProducts.isEmpty()) return;

            dsProducts.first();

            while (!dsProducts.eof()) {

                dsProducts.edit();

                dsProducts.fieldByName('QUANTITY').asInteger = -1;
                dsProducts.fieldByName('TOTAL').asFloat = - dsProducts.fieldByName('TOTAL').asFloat;
                dsProducts.fieldByName('F_TOTAL_TVAC').asFloat = - dsProducts.fieldByName('F_TOTAL_TVAC').asFloat;

                if(dsProducts.fieldByName('F_ISTIMESHEET').asInteger) {
                    this.Time.lockManagement(dsProducts.fieldByName('F_EXT_KEY').asFloat, 1, 0);
                }

                dsProducts.post();
                dsProducts.next();

            }
// this operation end with a commit on docuCtx and a closeContext

I never saw the second choice anywhere, in the old project I manage. Is it really a good idea ? I found more convinient to use the TDataSet.edit() / TDataSet.post() method, because you don't need to commit at each iteration;

Thanks in advance,

Loïc

Edit relation in Modal Window

Tue, 23 Apr 2019 12:06:09 +0000

Has anyone already created a form in a Modal window for editing the relation (for ex. Prod & Oppo)?
If so could you explain how you did this ?

Efficy Overflow Q&A - Recent questions tagged edit-relation

Is it better to "openEditContextRelation" or "TDataSet.edit() / TDataSet.post()" ?

Edit relation in Modal Window